Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42262: Py_NewRef() casts its argument to PyObject* #23626

Merged
merged 1 commit into from
Dec 3, 2020
Merged

bpo-42262: Py_NewRef() casts its argument to PyObject* #23626

merged 1 commit into from
Dec 3, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 3, 2020 •
edited by bedevere-bot
Loading

Write also unit tests on Py_NewRef() and Py_XNewRef().

https://bugs.python.org/issue42262

@vstinner
bpo-42262: Py_NewRef() casts its argument to PyObject*
728fc89 
Write also unit tests on Py_NewRef() and Py_XNewRef().
@vstinner
Copy link
Member Author

vstinner commented Dec 3, 2020

test_asyncio failed on Windows x64. I re-run the job.

@vstinner
Copy link
Member Author

vstinner commented Dec 3, 2020

test_asyncio failed again: https://bugs.python.org/issue42553

FAIL: test_call_later (test.test_asyncio.test_events.SelectEventLoopTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_asyncio\test_events.py", line 301, in test_call_later
    self.assertTrue(0.08 <= t1-t0 <= 0.8, t1-t0)
AssertionError: False is not true : 0.07799999999997453

@vstinner vstinner merged commit 8b6c4a9 into python:master Dec 3, 2020
@vstinner vstinner deleted the newref_cast branch December 3, 2020 13:01
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@vstinner @adorilson
bpo-42262: Py_NewRef() casts its argument to PyObject* (pythonGH-23626)
2bf2fd3 
Write also unit tests on Py_NewRef() and Py_XNewRef().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot