TST: unbreak tests on FREEBSD #23684
Closed
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add it on a Tuple ir List. |
|
Well, I would prefer to fix the issue that skipping it. Otherwise, there is a risk of forgetting this bug. |
|
It is ok is FreeBSD and AIX buildbots are broken for a few days. |
|
Closing in favor of fixing the problem in gh-23708 |
|
The code can be made with a function with tuples or lists, instead of writing the same 5 or 6 times. I can do this though, if You want this tell me. |
|
@fochoao what do you mean? I see this comment from 22 days ago as well. Can you be more specific: which function? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR gh-22088 I added extended a test that FREEBSD is not happy with.
This should unbreak the build on FREEBSD. I don't know why the original PR did not trip this, perhaps the buildbot was not running? Once the build is unbroken, I would be happy to hear from FREEBSD people why the test failed, it should not.