Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42681: Fix range checks for color and pair numbers in curses #23874

Merged
merged 10 commits into from
Jan 3, 2021
Merged

bpo-42681: Fix range checks for color and pair numbers in curses #23874

merged 10 commits into from
Jan 3, 2021

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Dec 20, 2020 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.8 needs backport to 3.9 only security fixes labels Dec 20, 2020
ghost
ghost approved these changes Dec 22, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit 1470edd into python:master Jan 3, 2021
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 1470edd6131c29b8a09ce012cdfee3afa269d553 3.9

@serhiy-storchaka serhiy-storchaka deleted the curses-colors-pairs branch January 3, 2021 20:51
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1470edd6131c29b8a09ce012cdfee3afa269d553 3.8

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jan 3, 2021
@serhiy-storchaka
[3.9] bpo-42681: Fix range checks for color and pair numbers in curses (
2f43b64 
pythonGH-23874).

(cherry picked from commit 1470edd)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-24077 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 3, 2021
serhiy-storchaka added a commit that referenced this pull request Jan 3, 2021
@serhiy-storchaka
[3.9] bpo-42681: Fix range checks for color and pair numbers in curses (
b0ee2b4 
GH-23874). (GH-24077)

(cherry picked from commit 1470edd)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jan 3, 2021
@serhiy-storchaka
[3.8] [3.9] bpo-42681: Fix range checks for color and pair numbers in…
de5e96f 
… curses (pythonGH-23874). (pythonGH-24077)

(cherry picked from commit 1470edd).
(cherry picked from commit b0ee2b4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jan 4, 2021
@serhiy-storchaka
[3.8] [3.9] bpo-42681: Fix range checks for color and pair numbers in…
82794ca 
… curses (GH-23874). (GH-24077) (GH-24079)

(cherry picked from commit 1470edd)
(cherry picked from commit b0ee2b4)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@serhiy-storchaka @adorilson
bpo-42681: Fix range checks for color and pair numbers in curses (pyt…
1ac09ed 
…honGH-23874)
@serhiy-storchaka serhiy-storchaka removed their assignment Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @asvetlov @the-knights-who-say-ni