Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42048: Document AC's defining_class converter #23978

Merged
merged 9 commits into from
Jan 20, 2021
Merged

bpo-42048: Document AC's defining_class converter #23978

merged 9 commits into from
Jan 20, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Dec 28, 2020 •
edited by miss-islington
Loading

Parts of this documentation is more or less taken/stolen directly from PEP 573

https://bugs.python.org/issue42048

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 28, 2020
@erlend-aasland
Copy link
Contributor Author

cc @vstinner, as promised at #22478 (comment)

vstinner
vstinner reviewed Jan 20, 2021
View reviewed changes
Erlend Egeberg Aasland and others added 2 commits January 20, 2021 10:28
@vstinner
Use PEP marker
38df615 
Co-authored-by: Victor Stinner <vstinner@python.org>
Address review
acf0f7e
@erlend-aasland
Copy link
Contributor Author

PTAL, @vstinner. I've expanded the zlib example, added some lines about heap types and PyType_FromModuleAndSpec, and added some lines about slot methods and _PyType_GetModuleByDef (together with a small example from the thread module). I also removed info about the calling convention.

vstinner
vstinner reviewed Jan 20, 2021
View reviewed changes
Erlend Egeberg Aasland and others added 3 commits January 20, 2021 11:27
vstinner
vstinner reviewed Jan 20, 2021
View reviewed changes
Erlend Egeberg Aasland and others added 2 commits January 20, 2021 12:01
@vstinner
Fix typo: follwing => following
97ec8e8 
Co-authored-by: Victor Stinner <vstinner@python.org>
Fix .rst bug: default role used
50a9143
vstinner
vstinner approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@erlend-aasland
Copy link
Contributor Author

@vstinner I guess the bot need a skip news flag? Or should I add a news item?

@vstinner vstinner merged commit e982fe4 into python:master Jan 20, 2021
@erlend-aasland erlend-aasland deleted the ac-document-defining-class branch January 20, 2021 11:20
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@adorilson
bpo-42048: Clinic Howto: Document AC's defining_class converter (pyth…
b662ac1 
…onGH-23978)
erlend-aasland pushed a commit to erlend-aasland/devguide that referenced this pull request Sep 8, 2023
@erlend-aasland
bpo-42048: Clinic Howto: Document AC's defining_class converter (pyth…
902a8f8 
…on/cpython#23978)
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Sep 13, 2023
bpo-42048: Clinic Howto: Document AC's defining_class converter (pyth…
403488f 
…on/cpython#23978)

GitHub-Issue-Link: python/cpython#86214
erlend-aasland pushed a commit to python/devguide that referenced this pull request Sep 26, 2023
@erlend-aasland
bpo-42048: Clinic Howto: Document AC's defining_class converter (pyth…
f314e51 
…on/cpython#23978)

GitHub-Issue-Link: python/cpython#86214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot