Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40077: Add traverse/clear/free to arraymodule #24066

Merged
merged 2 commits into from
Jan 3, 2021
Merged

bpo-40077: Add traverse/clear/free to arraymodule #24066

merged 2 commits into from
Jan 3, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 2, 2021 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor Author

@encukou, would you mind reviewing this?

shihai1991
shihai1991 approved these changes Jan 3, 2021
View reviewed changes
Copy link
Member

@shihai1991 shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just a nitpick: PyObject *m--> PyObject *module or PyObject *mod would be more exact.

@erlend-aasland
Copy link
Contributor Author

LGTM.

Just a nitpick: PyObject *m--> PyObject *module or PyObject *mod would be more exact.

I agree. I'll fix it.

@encukou encukou merged commit b8eb376 into python:master Jan 3, 2021
@encukou
Copy link
Member

encukou commented Jan 3, 2021

Thank you!

@erlend-aasland erlend-aasland deleted the bpo-40077/array-fix branch January 3, 2021 13:45
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@adorilson
bpo-40077: Add traverse/clear/free to arraymodule (pythonGH-24066)
1a9d7e6
@corona10 corona10 mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shihai1991 shihai1991 Awaiting requested review from shihai1991

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @encukou @shihai1991 @the-knights-who-say-ni @bedevere-bot