Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40810: Require SQLite 3.7.15 #24106

Merged
merged 1 commit into from
Jan 6, 2021
Merged

bpo-40810: Require SQLite 3.7.15 #24106

merged 1 commit into from
Jan 6, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 4, 2021 •
edited by bedevere-bot
Loading

Remove code required to support SQLite pre 3.7.15.

https://bugs.python.org/issue40810

@erlend-aasland
Copy link
Contributor Author

@berkerpeksag Would you mind reviewing this?

serhiy-storchaka
serhiy-storchaka approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, SQLite 3.7.15 was released 8 years ago, so I think we are safe to bump the minimal required version. But please wait for confirmation of other core developer.

bpo-40810: Require SQLite 3.7.15
93372c0 
Remove code required to support SQLite pre 3.7.15.
@erlend-aasland
Copy link
Contributor Author

Thanks, @serhiy-storchaka! If you've got a suggestion for another core dev that'd be interested in reviewing this, please feel free to request their review.

FYI, rebased onto master for the #24110 NEWS item fix.

@erlend-aasland
Copy link
Contributor Author

@pablogsal Would you mind reviewing this? (Ref. your review of #20909)

berkerpeksag
berkerpeksag approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd prefer stick to 3.7.15 for a while. I feel like we are getting a bit carried away with dropping support for older SQLite versions :)

@berkerpeksag berkerpeksag merged commit cf0b239 into python:master Jan 6, 2021
@erlend-aasland
Copy link
Contributor Author

LGTM, but I'd prefer stick to 3.7.15 for a while. I feel like we are getting a bit carried away with dropping support for older SQLite versions :)

Sure, I agree :) There's not too much support code laying around now, so I think we can stay at 3.7.15 for now. Thanks.

@erlend-aasland erlend-aasland deleted the require-sqlite-3.7.15 branch January 6, 2021 00:08
@erlend-aasland erlend-aasland mentioned this pull request Jan 10, 2021
Closed
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 24, 2021
bpo-43314: Remove SQLITE_OPEN_URI ifdef
14e9ce9 
SQLite 3.7.15 is required as by pythonGH-24106. SQLITE_OPEN_URI was added in
SQLite 3.7.7.
@erlend-aasland erlend-aasland mentioned this pull request Feb 24, 2021
Merged
berkerpeksag pushed a commit that referenced this pull request Feb 26, 2021
bpo-43314: Remove SQLITE_OPEN_URI ifdef (GH-24637)
3150754 
SQLite 3.7.15 is required as by GH-24106. SQLITE_OPEN_URI was added in
SQLite 3.7.7.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@adorilson
bpo-40810: Require SQLite 3.7.15 (pythonGH-24106)
b8fc2b2
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@adorilson
bpo-43314: Remove SQLITE_OPEN_URI ifdef (pythonGH-24637)
1176a2a 
SQLite 3.7.15 is required as by pythonGH-24106. SQLITE_OPEN_URI was added in
SQLite 3.7.7.
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jun 5, 2021
Sync with pythonGH-24106
d1efa55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @berkerpeksag @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot