Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42982: Increase suggested number of iterations of PBKDF2 to 250,000 #24276

Merged
merged 5 commits into from
Jan 27, 2022
Merged

bpo-42982: Increase suggested number of iterations of PBKDF2 to 250,000 #24276

merged 5 commits into from
Jan 27, 2022

Conversation

illia-v
Copy link
Contributor

@illia-v illia-v commented Jan 20, 2021 •
edited by bedevere-bot
Loading

@illia-v illia-v requested a review from tiran as a code owner January 20, 2021 20:16
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 20, 2021
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 20, 2021
@gpshead gpshead self-assigned this Jan 27, 2022
@gpshead gpshead merged commit 897ce90 into python:main Jan 27, 2022
@miss-islington
Copy link
Contributor

Thanks @illia-v for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2022
@illia-v @miss-islington
bpo-42982: Improve the text on suggested number of iterations of PBKD…
5998c02 
…F2 (pythonGH-24276)

Less specific number wording (as there is no one right number - the old 100k is too big for some applications and woefully small for others). We now link to NIST SP 800-132 to tell people what to read in there on how to decide for their application.

Co-authored-by: Gregory P. Smith <greg@krypto.org> [Google]
(cherry picked from commit 897ce90)

Co-authored-by: Illia Volochii <illia.volochii@gmail.com>
@bedevere-bot
Copy link

GH-30951 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 27, 2022
miss-islington added a commit that referenced this pull request Jan 27, 2022
@miss-islington @illia-v
bpo-42982: Improve the text on suggested number of iterations of PBKD…
1ecc98d 
…F2 (GH-24276)

Less specific number wording (as there is no one right number - the old 100k is too big for some applications and woefully small for others). We now link to NIST SP 800-132 to tell people what to read in there on how to decide for their application.

Co-authored-by: Gregory P. Smith <greg@krypto.org> [Google]
(cherry picked from commit 897ce90)

Co-authored-by: Illia Volochii <illia.volochii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran Awaiting requested review from tiran tiran is a code owner

Assignees

@gpshead gpshead

Labels
docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@illia-v @miss-islington @bedevere-bot @gpshead @the-knights-who-say-ni