Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40077: Convert zoneinfo type to heap type #24481

Closed
wants to merge 4 commits into from
Closed

bpo-40077: Convert zoneinfo type to heap type #24481

wants to merge 4 commits into from

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 8, 2021 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor Author

cc. @corona10 @vstinner

FYI: _zoneinfo is already multi-phase init.

@pablogsal
Copy link
Member

I would recommend waiting for #24065 (comment) before continuing with heap type changes

@erlend-aasland
Copy link
Contributor Author

I would recommend waiting for #24065 (comment) before continuing with heap type changes

No problem :)

shihai1991
shihai1991 reviewed Feb 8, 2021
View reviewed changes
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 11, 2021
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Oct 22, 2021 •
edited by bedevere-bot
Loading

I would recommend waiting for #24065 (comment) before continuing with heap type changes

BTW, I just skimmed through PEP 630 Isolating Extension Modules again, and I started wondering why it is not enough? It is well written, accepted/active, and it explains the rationale of heap types well, and it even advocates that the standard library should be an "early adopter". Has there been an official statement from the SC regarding halting bpo-40077? Just wondering :)

@erlend-aasland
Copy link
Contributor Author

FYI, PEP-687 was just accepted.

@corona10 corona10 mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shihai1991 shihai1991 shihai1991 left review comments

Assignees
No one assigned
Labels
awaiting review stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @pablogsal @shihai1991 @the-knights-who-say-ni @bedevere-bot