bpo-37146: Deactivate opcode cache only when using huntrleaks in the test suite #24643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 0372254fc3556cc2d3a7fb07f39f38b0b86ccb29 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
methane
reviewed
Feb 25, 2021
| co->co_opcache_flag++; | ||
| if (co->co_opcache_flag == OPCACHE_MIN_RUNS) { | ||
| if (co->co_opcache_flag == opcache_min_runs) { |
There was a problem hiding this comment.
This may increase memory access in hot path. Would you run pypeformance to ensure no performance regression?
There was a problem hiding this comment.
Sure, will run this over the weekend.
There was a problem hiding this comment.
Seems that there is no much different over the noise level:
❯ pyperf compare_to json/* --table --min-speed 2 -G
+----------------+--------------------------------------+-----------------------------------------+
| Benchmark | 2021-02-27_11-31-master-c71d24f55828 | 2021-02-27_19-33-bpo-37136-a9680bcf9b84 |
+================+======================================+=========================================+
| unpickle | 17.0 us | 17.4 us: 1.02x slower |
+----------------+--------------------------------------+-----------------------------------------+
| pickle | 13.2 us | 13.7 us: 1.04x slower |
+----------------+--------------------------------------+-----------------------------------------+
| nqueens | 121 ms | 126 ms: 1.04x slower |
+----------------+--------------------------------------+-----------------------------------------+
| Geometric mean | (ref) | 1.00x slower |
+----------------+--------------------------------------+-----------------------------------------+
Benchmark hidden because not significant (56): xml_etree_parse, scimark_sor, unpickle_list, nbody, unpack_sequence, regex_v8, chaos, meteor_contest, telco, python_startup, genshi_text, regex_compile, python_startup_no_site, json_loads, regex_dna, logging_simple, sympy_sum, xml_etree_iterparse, scimark_sparse_mat_mult, xml_etree_process, richards, chameleon, sqlalchemy_declarative, django_template, hexiom, pathlib, json_dumps, tornado_http, sympy_str, unpickle_pure_python, pyflate, pidigits, go, regex_effbot, deltablue, sympy_expand, xml_etree_generate, float, genshi_xml, logging_silent, raytrace, fannkuch, sqlalchemy_imperative, scimark_monte_carlo, logging_format, 2to3, sympy_integrate, mako, pickle_dict, pickle_list, spectral_norm, dulwich_log, sqlite_synth, scimark_lu, pickle_pure_python, scimark_fft, crypto_pyaes
|
Thanks! |
vstinner
reviewed
Feb 27, 2021
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
gvanrossum
approved these changes
Feb 27, 2021
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
gvanrossum
approved these changes
Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37146
This allows us to run the opcode cache in debug mode, as catching bugs related to the opcode cache was quite hard due to it not being activated by default in this case.