Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-20364: Improve sqlite3 placeholder docs #25003

Merged
merged 11 commits into from
Apr 14, 2021
Merged

bpo-20364: Improve sqlite3 placeholder docs #25003

merged 11 commits into from
Apr 14, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Mar 23, 2021 •
edited
Loading

Co-authored-by: Terry J. Reedy

https://bugs.python.org/issue20364

@erlend-aasland
Copy link
Contributor Author

@berkerpeksag, @terryjreedy: would you mind taking a look at this?

Fidget-Spinner
Fidget-Spinner reviewed Apr 5, 2021
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an sqllite3 expert by any means, so I'll leave verifying the content's accuracy to someone else ;).

Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
@Fidget-Spinner
parametrized => parameterized
f19c531 
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@erlend-aasland
Copy link
Contributor Author

Thanks for reviewing, @Fidget-Spinner, I appreciate your comments 😃

Fidget-Spinner
Fidget-Spinner approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for improving the docs :).

berkerpeksag
berkerpeksag requested changes Apr 14, 2021
View reviewed changes
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/includes/sqlite3/execute_1.py Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

@berkerpeksag
Copy link
Member

Ah, can you also fix the following error?

Warning, treated as error:
[library/sqlite3:98] ":name" found in "cur.execute("select * from lang where lang_name=:name and lang_age=:age","
Makefile:49: recipe for target 'build' failed

You'll probably need to update Doc/tools/susp-ignored.csv.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 14, 2021 •
edited
Loading

You'll probably need to update Doc/tools/susp-ignored.csv.

Oh, I've never seen this before :) c2366b5 did not fix it, but I discovered the make suspicious target in Doc. Fix comin' up pretty soon.

UPDATE: Done. Fixed in f3ed86e

@erlend-aasland
Copy link
Contributor Author

Since this is a doc update, we'd want to backport it to 3.9 and 3.8, right?

@berkerpeksag berkerpeksag added the needs backport to 3.9 only security fixes label Apr 14, 2021
@berkerpeksag berkerpeksag merged commit 3386ca0 into python:master Apr 14, 2021
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the bpo-20364 branch April 14, 2021 12:29
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 14, 2021
@miss-islington
bpo-20364: Improve sqlite3 placeholder docs (pythonGH-25003)
8827074 
(cherry picked from commit 3386ca0)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

GH-25402 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Apr 14, 2021
@erlend-aasland
Copy link
Contributor Author

Thanks for reviewing, @berkerpeksag !

berkerpeksag pushed a commit that referenced this pull request Apr 14, 2021
@miss-islington
bpo-20364: Improve sqlite3 placeholder docs (GH-25003)
95e4431 
(cherry picked from commit 3386ca0)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aasland erlend-aasland mentioned this pull request May 10, 2021
Merged
@erlend-aasland erlend-aasland mentioned this pull request Jul 27, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erlend-aasland @bedevere-bot @berkerpeksag @miss-islington @Fidget-Spinner @the-knights-who-say-ni