Skip to content

bpo-33164: blake2: Fix Coverity scan #25060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
methane merged 1 commit into from
Mar 30, 2021
Merged

bpo-33164: blake2: Fix Coverity scan #25060

methane merged 1 commit into from
Mar 30, 2021

Conversation

@methane
Copy link
Member

@methane methane commented Mar 29, 2021 •
edited by bedevere-bot
Loading

@methane methane requested a review from tiran as a code owner March 29, 2021 03:25
vstinner
vstinner approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stratakis
Copy link
Contributor

stratakis commented Mar 29, 2021

Thanks for the fix. Should also the 3.8 backport label be added, as the blake2 module was updated on 3.8?

@methane
Copy link
Member Author

methane commented Mar 30, 2021

Thanks for the fix. Should also the 3.8 backport label be added, as the blake2 module was updated on 3.8?

You are right. I thought Python 3.8 become security-fix only mode, but it was wrong. There is one more bugfix release for 3.8.

@methane methane merged commit 068ebf9 into python:master Mar 30, 2021
@methane methane deleted the blake2-memmove branch March 30, 2021 03:25
@miss-islington
Copy link
Contributor

miss-islington commented Mar 30, 2021

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 30, 2021

Sorry @methane, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 068ebf9729d440cef03e4c57e3db83c851146172 3.9

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 30, 2021
@methane @miss-islington
bpo-33164: blake2: Fix Coverity scan (pythonGH-25060)
d946180 
(cherry picked from commit 068ebf9)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Mar 30, 2021

GH-25091 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Mar 30, 2021
@miss-islington @methane
bpo-33164: blake2: Fix Coverity scan (GH-25060)
6af3a94 
(cherry picked from commit 068ebf9)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Mar 30, 2021

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Mar 30, 2021

GH-25092 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 30, 2021
@methane @miss-islington
bpo-33164: blake2: Fix Coverity scan (pythonGH-25060)
30915ca 
(cherry picked from commit 068ebf9)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
miss-islington added a commit that referenced this pull request Mar 30, 2021
@miss-islington @methane
bpo-33164: blake2: Fix Coverity scan (GH-25060)
05429c9 
(cherry picked from commit 068ebf9)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@tiran
Copy link
Member

tiran commented Apr 17, 2021

Please respect code owner responsibility and give me at least a change to review and comment on PRs that affect my area of expertise. I'm not happy that you pushed the PR given me the opportunity to very it.

@methane
Copy link
Member Author

methane commented Apr 18, 2021

I'm sorry about that.

This pull request is just resurrecting your change that I lost by mistake. That's why I merge this without waiting you.

This was referenced May 11, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees

@methane methane

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@methane @stratakis @miss-islington @bedevere-bot @tiran @vstinner @the-knights-who-say-ni