bpo-43660: Fix crash when displaying exceptions with custom values for sys.stderr #25075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
erlend-aasland
approved these changes
Mar 29, 2021
vstinner
reviewed
Mar 29, 2021
Lib/test/test_sys.py
Outdated
| # If the default displayhook doesn't take a strong reference | ||
| # to sys.stderr the following code can crash. See bpo-43660 | ||
| # for more details. | ||
| code = """ |
Member
There was a problem hiding this comment.
Could you please use textwrap.dedent() for that?
vstinner
approved these changes
Mar 29, 2021
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, but I added a minor remark on the test ;-)
Lib/test/test_sys.py
Outdated
Member
There was a problem hiding this comment.
thanks to dedent(), it can be removed ;-)
Contributor
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9. |
|
GH-25083 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 29, 2021
…r sys.stderr (pythonGH-25075) (cherry picked from commit 09b90a0) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
|
GH-25084 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 29, 2021
…r sys.stderr (pythonGH-25075) (cherry picked from commit 09b90a0) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Contributor
|
Sorry, @pablogsal, I could not cleanly backport this to |
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Mar 29, 2021
…ues for sys.stderr (pythonGH-25075). (cherry picked from commit 09b90a0) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
|
GH-25085 is a backport of this pull request to the 3.7 branch. |
pablogsal
added a commit
that referenced
this pull request
Mar 29, 2021
pablogsal
added a commit
that referenced
this pull request
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
https://bugs.python.org/issue43660