Fix assertion of pop() result in test_issue_4920 #25209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pop method of MutableSet iterates the underlying set object to choose the item to remove. According the the Python language reference "sets do not record element position or order of insertion". Changes the test to not assert concrete result of pop, but just that it was an item from the set, and that the set shrunk by one.
rhettinger
approved these changes
Apr 7, 2021
|
Thanks @steve-s for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 7, 2021
Changes the test to not assert concrete result of pop, but just that it was an item from the set, and that the set shrunk by one. (cherry picked from commit 453074c) Co-authored-by: Stepan Sindelar <me@stevesindelar.cz>
|
GH-25269 is a backport of this pull request to the 3.9 branch. |
|
Thanks @steve-s for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 7, 2021
Changes the test to not assert concrete result of pop, but just that it was an item from the set, and that the set shrunk by one. (cherry picked from commit 453074c) Co-authored-by: Stepan Sindelar <me@stevesindelar.cz>
|
GH-25270 is a backport of this pull request to the 3.8 branch. |
rhettinger
pushed a commit
that referenced
this pull request
Apr 7, 2021
rhettinger
pushed a commit
that referenced
this pull request
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the test to not assert concrete result of
popbut just that it was an item from the set, and that the set shrunk by one.The
popmethod ofMutableSetiterates the underlying set object to choose the item to remove. According the the Python language reference "sets do not record element position or order of insertion".Note: changing the values in the original test to, for example:
gives
Background: we discovered this issue while developing GraalPython, where a small difference in internal implementation leads to
pop()giving a different value in this case.