-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
Remove duplicated text for iterable unpacking #25212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
I don't think the else and indentation really improves the readability of the text here as it is implied by it being an another condition. For example something like this would suffice in my opinion
|
@Numerlor, I agree, but I only want to eliminate duplication in this PR as it is obviously wrong. As for the content itself, I will leave it to the python maintainer. |
This PR is stale because it has been open for 30 days with no activity. |
Thanks @jiasli for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
GH-32277 is a backport of this pull request to the 3.10 branch. |
GH-32278 is a backport of this pull request to the 3.9 branch. |
Thanks for your contribution, and sorry it had to wait for so long! |
…ythonGH-25212) (cherry picked from commit 4f5d56f) Co-authored-by: Jiashuo Li <4003950+jiasli@users.noreply.github.com>
…ythonGH-25212) (cherry picked from commit 4f5d56f) Co-authored-by: Jiashuo Li <4003950+jiasli@users.noreply.github.com>
This text is duplicated several lines later in L139-L141:
cpython/Doc/reference/simple_stmts.rst
Lines 139 to 141 in c56f9df
Putting it after the first
Else:
causes confusion.