Skip to content

bpo-38530: Offer suggestions on NameError #25397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2021
Merged

bpo-38530: Offer suggestions on NameError #25397

merged 2 commits into from
Apr 14, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 14, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from markshannon as a code owner April 14, 2021 02:56
@pablogsal pablogsal requested review from methane and vstinner April 14, 2021 02:58
@pablogsal pablogsal force-pushed the nameerrors branch 6 times, most recently from 5b98377 to 6e4fe45 Compare April 14, 2021 03:14
isidentical
isidentical approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@isidentical isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vstinner
vstinner reviewed Apr 14, 2021
View reviewed changes
@pablogsal @isidentical @vstinner
Apply suggestions from code review
7c777f9 
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
vstinner approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablogsal pablogsal merged commit 5bf8bf2 into python:master Apr 14, 2021
@pablogsal pablogsal deleted the nameerrors branch April 14, 2021 14:11
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 10, 2021
@Snowapril
Implement keyword suggestion routine
37075f4 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 11, 2021
@Snowapril
Implement keyword suggestion routine
9c5e9c1 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 11, 2021
@Snowapril
Implement keyword suggestion routine
be8f93c 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 11, 2021
@Snowapril
Implement keyword suggestion routine
3953327 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 11, 2021
@Snowapril
Implement keyword suggestion routine
2edd1d5 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 13, 2021
@Snowapril
Implement keyword suggestion routine
768a0da 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 13, 2021
@Snowapril
Implement keyword suggestion routine
19bab40 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 13, 2021
@Snowapril
Implement keyword suggestion routine
4affb59 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 13, 2021
@Snowapril
Implement keyword suggestion routine
8618864 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 14, 2021
@Snowapril
Implement keyword suggestion routine
2f51491 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 14, 2021
@Snowapril
Implement keyword suggestion routine
c30fa12 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 14, 2021
@Snowapril
Implement keyword suggestion routine
8aee5c2 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 15, 2021
@Snowapril
Implement keyword suggestion routine
24057aa 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 16, 2021
@Snowapril
Implement keyword suggestion routine
dd8ce45 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 18, 2021
@Snowapril
Implement keyword suggestion routine
860785d 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 18, 2021
@Snowapril
Implement keyword suggestion routine
da629a0 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 20, 2021
@Snowapril
Implement keyword suggestion routine
6ae5c3b 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 20, 2021
@Snowapril
Implement keyword suggestion routine
6339390 
`suggestions.rs` is almost porting of implementation of
[this](python/cpython#16856) and
[this](python/cpython#25397).

Signed-off-by: snowapril <sinjihng@gmail.com>
@MicahGale MicahGale mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@isidentical isidentical isidentical approved these changes

@markshannon markshannon Awaiting requested review from markshannon

@methane methane Awaiting requested review from methane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @vstinner @isidentical @the-knights-who-say-ni @bedevere-bot