Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42725: Render annotations effectless on symbol table with PEP 563 #25583

Merged
merged 2 commits into from
May 3, 2021
Merged

bpo-42725: Render annotations effectless on symbol table with PEP 563 #25583

merged 2 commits into from
May 3, 2021

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented Apr 25, 2021 •
edited by bedevere-bot
Loading

@isidentical isidentical changed the title bpo-42725: Don't process annotations on the symbol table bpo-42725: Render annotations effectless on symbol table Apr 25, 2021
@isidentical isidentical changed the title bpo-42725: Render annotations effectless on symbol table bpo-42725: Render annotations effectless on symbol table with PEP 563 Apr 25, 2021
@isidentical isidentical requested a review from pablogsal April 25, 2021 19:51
pablogsal
pablogsal reviewed May 1, 2021
View reviewed changes
Python/symtable.c Outdated Show resolved Hide resolved
pablogsal
pablogsal reviewed May 1, 2021
View reviewed changes
Python/symtable.c Outdated Show resolved Hide resolved
pablogsal
pablogsal reviewed May 1, 2021
View reviewed changes
Python/symtable.c Outdated Show resolved Hide resolved
@isidentical
Copy link
Member Author 

 $ ./python -m test -R3:3 test_symtable test_future
0:00:00 load avg: 2.61 Run tests sequentially
0:00:00 load avg: 2.61 [1/2] test_symtable
beginning 6 repetitions
123456
......
0:00:00 load avg: 2.61 [2/2] test_future
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

All 2 tests OK.

Total duration: 565 ms
Tests result: SUCCESS

@isidentical isidentical requested a review from pablogsal May 1, 2021 10:23
@isidentical isidentical added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 3, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @isidentical for commit 7493334 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 3, 2021
@isidentical isidentical merged commit ad106c6 into python:master May 3, 2021
@buermarc buermarc mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NAPADAI NAPADAI NAPADAI approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isidentical @bedevere-bot @pablogsal @NAPADAI @the-knights-who-say-ni