Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42627: Fix wrong parsing of Windows registry proxy settings #26307

Merged
merged 24 commits into from
May 11, 2022
Merged

bpo-42627: Fix wrong parsing of Windows registry proxy settings #26307

merged 24 commits into from
May 11, 2022

Conversation

CrazyBoyFeng
Copy link
Contributor

@CrazyBoyFeng CrazyBoyFeng commented May 22, 2021 •
edited
Loading

In Windows registry proxy settings, https=host:456 does not mean that the proxy server communicates with the client through the HTTPS protocol, but it means that the proxy server proxies the client's traffic to the HTTPS website. The proxy server itself communicates with the client through the HTTP protocol by default.

fix pypa/pip#9568 fix pypa/pip#9614 fix urllib3/urllib3#2164 fix psf/requests#5740

https://bugs.python.org/issue42627

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@CrazyBoyFeng

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@CrazyBoyFeng CrazyBoyFeng marked this pull request as ready for review May 24, 2021 13:48
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@testinguser

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

CrazyBoyFeng and others added 3 commits May 28, 2021 14:17
@CrazyBoyFeng
Remove support for multi proxy per one protocol
dc2e781 
Keep backward compatibility
@CrazyBoyFeng
Merge branch 'python:main' into fix-issue-42627
2edd42a
@CrazyBoyFeng
Use SOCKS proxy for HTTP(S) protocols
33f07b2 
To compat with customary formats from software such as `requests[socks]`
keuin
keuin reviewed Jun 8, 2021
View reviewed changes
Lib/urllib/request.py Outdated Show resolved Hide resolved
@cubercsl cubercsl mentioned this pull request Jul 3, 2021
Closed
zooba
zooba reviewed Sep 7, 2021
View reviewed changes
Lib/urllib/request.py Outdated Show resolved Hide resolved
@CrazyBoyFeng CrazyBoyFeng requested a review from zooba September 8, 2021 09:31
@jiasli jiasli mentioned this pull request Sep 15, 2021
Closed
@zooba
Copy link
Member

zooba commented Sep 16, 2021

@CrazyBoyFeng Looks like you're going to hit a known error in CI right now. Merging the latest from master should fix it.

@CrazyBoyFeng
Copy link
Contributor Author

I've synced the branch to the latest, hope this works.

@zooba zooba added OS-windows needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels May 11, 2022
@miss-islington
Copy link
Contributor

Thanks @CrazyBoyFeng for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @CrazyBoyFeng for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @CrazyBoyFeng for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 11, 2022
@CrazyBoyFeng @miss-islington
bpo-42627: Fix incorrect parsing of Windows registry proxy settings (p…
cefa718 
…ythonGH-26307)

(cherry picked from commit b69297e)

Co-authored-by: 狂男风 <CrazyBoyFeng@Live.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 11, 2022
@bedevere-bot
Copy link

GH-92684 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 11, 2022
@CrazyBoyFeng @miss-islington
bpo-42627: Fix incorrect parsing of Windows registry proxy settings (p…
702dacf 
…ythonGH-26307)

(cherry picked from commit b69297e)

Co-authored-by: 狂男风 <CrazyBoyFeng@Live.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 11, 2022
@bedevere-bot
Copy link

GH-92685 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 11, 2022
@CrazyBoyFeng @miss-islington
bpo-42627: Fix incorrect parsing of Windows registry proxy settings (p…
c067672 
…ythonGH-26307)

(cherry picked from commit b69297e)

Co-authored-by: 狂男风 <CrazyBoyFeng@Live.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 11, 2022
@bedevere-bot
Copy link

GH-92686 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request May 11, 2022
@miss-islington @CrazyBoyFeng
bpo-42627: Fix incorrect parsing of Windows registry proxy settings (G…
5a33643 
…H-26307)

(cherry picked from commit b69297e)

Co-authored-by: 狂男风 <CrazyBoyFeng@Live.com>
miss-islington added a commit that referenced this pull request May 11, 2022
@miss-islington @CrazyBoyFeng
bpo-42627: Fix incorrect parsing of Windows registry proxy settings (G…
65d2dfd 
…H-26307)

(cherry picked from commit b69297e)

Co-authored-by: 狂男风 <CrazyBoyFeng@Live.com>
zooba pushed a commit that referenced this pull request May 12, 2022
@miss-islington @CrazyBoyFeng
bpo-42627: Fix incorrect parsing of Windows registry proxy settings (G…
9743524 
…H-26307)

(cherry picked from commit b69297e)

Co-authored-by: 狂男风 <CrazyBoyFeng@Live.com>
@findix findix mentioned this pull request May 27, 2022
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @CrazyBoyFeng @hello-adam
bpo-42627: Fix incorrect parsing of Windows registry proxy settings (p…
ac9fdc2 
…ythonGH-26307)

(cherry picked from commit b69297e)

Co-authored-by: 狂男风 <CrazyBoyFeng@Live.com>
@Myoufer Myoufer mentioned this pull request Dec 4, 2022
Closed
@dyhkwong dyhkwong mentioned this pull request Dec 20, 2022
Closed
@akynazh akynazh mentioned this pull request Feb 19, 2023
Closed
2 tasks
@LaoshuBaby LaoshuBaby mentioned this pull request Apr 16, 2023
Open
@samschott samschott mentioned this pull request May 4, 2023
Closed
@cyfex
Copy link

cyfex commented May 8, 2023

In Ubuntu 22.04, pip 23.1.2, python 3.10, this issue is still an issue. It seems not to be able to handle socks5 proxy properly.

@zooba
Copy link
Member

zooba commented May 8, 2023

Please file a new issue. It's no good commenting on an already completed PR that had nothing to do with your concern.

@python python locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@keuin keuin keuin left review comments

@zooba zooba zooba left review comments

Assignees
No one assigned
Labels
OS-windows
Projects
None yet
Milestone
No milestone
9 participants
@CrazyBoyFeng @the-knights-who-say-ni @zooba @gfxonline @sethmlarson @miss-islington @bedevere-bot @cyfex @keuin