bpo-43693: Add the MAKE_CELL opcode and interleave fast locals offsets. #26396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
reviewed
May 27, 2021
ericsnowcurrently
force-pushed
the
add-make-cell
branch
from
24ecd90 to
b4ba659
Compare
ericsnowcurrently
force-pushed
the
add-make-cell
branch
from
b4ba659 to
4dceac6
Compare
markshannon
reviewed
Jun 4, 2021
| @@ -181,14 +181,16 @@ def jabs_op(name, op): | |||
| def_op('MAKE_FUNCTION', 132) # Flags | |||
| def_op('BUILD_SLICE', 133) # Number of items | |||
|
|
|||
| def_op('LOAD_CLOSURE', 135) | |||
There was a problem hiding this comment.
My initial impression was that MAKE_CELL should be at the front of the cell-related list and I figured it would be better to preserve the gap at 134. I figured it wouldn't matter but if it's a problem I can put MAKE_CELL at 139.
Misc/NEWS.d/next/Core and Builtins/2021-05-26-19-10-47.bpo-43693.1KSG9u.rst
Outdated
Show resolved
Hide resolved
ericsnowcurrently
force-pushed
the
add-make-cell
branch
from
4975013 to
16c3424
Compare
ericsnowcurrently
force-pushed
the
add-make-cell
branch
from
16c3424 to
2ea0f06
Compare
ericsnowcurrently
force-pushed
the
add-make-cell
branch
from
2ea0f06 to
5a4d984
Compare
ericsnowcurrently
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 05accc0 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Jun 8, 2021
…s offsets. (pythongh-26396)" This reverts commit 631f993.
pablogsal
added a commit
that referenced
this pull request
Jun 8, 2021
ericsnowcurrently
added a commit
to ericsnowcurrently/cpython
that referenced
this pull request
Jun 8, 2021
…cals offsets. (pythongh-26396)" That commit (3fe921c) was reverted in pythonGH-26597 (3fe921c).
ericsnowcurrently
added a commit
that referenced
this pull request
Jun 8, 2021
This was reverted in GH-26596 (commit 6d518bb) due to some bad memory accesses. * Add the MAKE_CELL opcode. (gh-26396) The memory accesses have been fixed. https://bugs.python.org/issue43693
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves logic out of the frame initialization code and into the compiler and eval loop. Doing so simplifies the runtime code and allows us to optimize it better.
https://bugs.python.org/issue43693