Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43858: Add logging.getLevelNamesMapping() #26459

Merged
merged 12 commits into from
Jun 3, 2021
Merged

bpo-43858: Add logging.getLevelNamesMapping() #26459

merged 12 commits into from
Jun 3, 2021

Conversation

akulakov
Copy link
Contributor

@akulakov akulakov commented May 31, 2021 •
edited by bedevere-bot
Loading

Added a function that returns a copy of a dict of logging levels.

https://bugs.python.org/issue43858

@akulakov akulakov requested a review from vsajip as a code owner May 31, 2021 04:46
ericvsmith
ericvsmith requested changes May 31, 2021
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs tests. In particular it should add tests that a copy is returned.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@akulakov
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ericvsmith May 31, 2021 15:04
ericvsmith
ericvsmith requested changes May 31, 2021
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me. @vsajip : I'll let you have the final word.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

vsajip
vsajip requested changes May 31, 2021
View reviewed changes
ericvsmith
ericvsmith reviewed Jun 1, 2021
View reviewed changes
Misc/NEWS.d/next/Library/2021-05-31-04-51-02.bpo-43858.r7LOu6.rst Outdated
@@ -0,0 +1 @@
Added a function that returns a copy of a dict of logging levels: func::`logging.getLevelNamesMapping()`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I look at this: isn't the correct syntax:

:func:`logging.getLevelNamesMapping`

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, well spotted!

@akulakov
Copy link
Contributor Author

akulakov commented Jun 1, 2021

@vsajip @ericvsmith Pushed an update per comments, please take a look!

ericvsmith
ericvsmith reviewed Jun 1, 2021
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the one small item I mentioned, this looks good to me.

Misc/NEWS.d/next/Library/2021-05-31-04-51-02.bpo-43858.r7LOu6.rst Outdated
@@ -0,0 +1 @@
Added a function that returns a copy of a dict of logging levels: :func:`logging.getLevelNamesMapping()`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that :func: adds the parens, so you should leave them off in this message. I've looked at other files, and they don't have the parens.

@akulakov
Copy link
Contributor Author

akulakov commented Jun 1, 2021

@ericvsmith I fixed the parens, please take a look..

vsajip
vsajip requested changes Jun 2, 2021
View reviewed changes
Copy link
Member

@vsajip vsajip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental double-definition in test?

Lib/test/test_logging.py Outdated
@@ -4390,6 +4390,15 @@ def rec():
self.assertNotIn("Cannot recover from stack overflow.", err)
self.assertEqual(rc, 1)

def test_get_level_names_mapping(self):
def test_get_level_names_mapping(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you meant this double level of indentation! That causes the test to do nothing effective 😞

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, somehow doubling made it hard to spot for me..

@akulakov
Copy link
Contributor Author

akulakov commented Jun 2, 2021

@vsajip Fixed the doubled test..

ericvsmith
ericvsmith reviewed Jun 2, 2021
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. Thanks, @akulakov !

@akulakov akulakov changed the title bpo-43858: Add logging.getLevelNamesDict() bpo-43858: Add logging.getLevelNamesMapping() Jun 2, 2021
@miss-islington miss-islington merged commit 8b93f0e into python:main Jun 3, 2021
@akulakov
Copy link
Contributor Author

akulakov commented Jun 5, 2021

@ericvsmith and @vsajip much thanks for the help with the PR!

@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith requested changes

@vsajip vsajip vsajip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akulakov @bedevere-bot @vsajip @ericvsmith @the-knights-who-say-ni @miss-islington