Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42892: fix email multipart attribute error #26903

Merged
merged 8 commits into from
Jul 30, 2021
Merged

bpo-42892: fix email multipart attribute error #26903

merged 8 commits into from
Jul 30, 2021

Conversation

akulakov
Copy link
Contributor

@akulakov akulakov commented Jun 24, 2021 •
edited by bedevere-bot
Loading

Based on the patch by @bitdancer in the ticket.
Unit test updates by Andrei K.

https://bugs.python.org/issue42892

@akulakov akulakov requested a review from a team as a code owner June 24, 2021 19:11
iritkatriel
iritkatriel reviewed Jun 27, 2021
View reviewed changes
Lib/test/test_email/test_message.py Outdated Show resolved Hide resolved
Lib/test/test_email/test_message.py Outdated Show resolved Hide resolved
@akulakov
Copy link
Contributor Author

@iritkatriel I pushed an update, please take a look.. note the test failure is unrelated to the PR (it says that grammar.new file is missing).

@iritkatriel
Copy link
Member

LGTM, but would be good if @bitdancer also had a look.

@akulakov
Copy link
Contributor Author

@iritkatriel thanks for the review :)

@iritkatriel iritkatriel requested a review from bitdancer July 15, 2021 12:41
@ambv ambv added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jul 30, 2021
@ambv ambv merged commit e3f877c into python:main Jul 30, 2021
@miss-islington
Copy link
Contributor

Thanks @akulakov for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 30, 2021
@akulakov @miss-islington
bpo-42892: fix email multipart attribute error (pythonGH-26903)
a74974f 
(cherry picked from commit e3f877c)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@bedevere-bot
Copy link

GH-27492 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 30, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 30, 2021
@akulakov @miss-islington
bpo-42892: fix email multipart attribute error (pythonGH-26903)
3a2b602 
(cherry picked from commit e3f877c)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 30, 2021
@bedevere-bot
Copy link

GH-27493 is a backport of this pull request to the 3.9 branch.

ambv pushed a commit that referenced this pull request Jul 30, 2021
@miss-islington @akulakov
bpo-42892: fix email multipart attribute error (GH-26903) (GH-27492)
6f95002 
(cherry picked from commit e3f877c)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
ambv pushed a commit that referenced this pull request Jul 30, 2021
@miss-islington @akulakov
bpo-42892: fix email multipart attribute error (GH-26903) (GH-27493)
0f42b72 
(cherry picked from commit e3f877c)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel left review comments

@bitdancer bitdancer Awaiting requested review from bitdancer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akulakov @iritkatriel @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni