Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Minor adjustment of socket.create_server docs #26938

Merged
merged 3 commits into from
May 20, 2022

Conversation

pavel-lexyr
Copy link
Contributor

No description provided.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@pavel-lexyr

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Lib/socket.py Outdated Show resolved Hide resolved
Lib/socket.py Outdated Show resolved Hide resolved
@@ -661,7 +661,7 @@ The following functions all create :ref:`socket objects <socket-objects>`.
.. function:: create_server(address, *, family=AF_INET, backlog=None, reuse_port=False, dualstack_ipv6=False)

Convenience function which creates a TCP socket bound to *address* (a 2-tuple
``(host, port)``) and return the socket object.
``(host, port)``) and returns the socket object.
Copy link
Contributor

@erlend-aasland erlend-aasland May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Other methods in this file are documented using the imperative mood. Rewording this whole section (this method) is out of scope of this PR, though.

@erlend-aasland erlend-aasland self-assigned this May 20, 2022
@erlend-aasland erlend-aasland changed the title Minor doc improvements for socket.create_server Docs: Minor adjustment of socket.create_server docs May 20, 2022
@erlend-aasland erlend-aasland changed the title Docs: Minor adjustment of socket.create_server docs Doc: Minor adjustment of socket.create_server docs May 20, 2022
@erlend-aasland erlend-aasland merged commit a637c09 into python:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants