bpo-43950: make BinOp specializations more reliable #27126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammaraskar
reviewed
Jul 13, 2021
Lib/test/test_traceback.py
Outdated
| self.assertEqual(specialization_line.lstrip(), expected_specialization) | ||
|
|
||
| def test_specialization_variations(self): | ||
| self.assertSpecialized(lambda: 1/0, "~^~") |
There was a problem hiding this comment.
Would you mind lining up the carets with the code just so these tests are easier to read.
There was a problem hiding this comment.
I have pushed to your fork the fix
pablogsal
force-pushed
the
bpo-43950-proper-specialization
branch
from
442a9e0 to
85eabf2
Compare
pablogsal
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we are parsing the correct segment (
[right->end, left->start)) for BinOps.https://bugs.python.org/issue43950