Skip to content

Perform 'blurb split' for 3.3. #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Perform 'blurb split' for 3.3. #2715

wants to merge 1 commit into from

Conversation

larryhastings
Copy link
Contributor

No description provided.

Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick perusal LGTM.

@ned-deily
Copy link
Member

See comments on #2719 for master, e.g. breaking doc builds of Doc/whatsnew/changelog.rst. But I wonder whether we should even bother doing this for 3.3 since it is so close to end-of-life and the Doc/Makefile for 3.3 is much older, e.g. it doesn't use venv or pip to build docs but rather downloads build tools using svn! At least, let's hold off on 3.3 until I've had a chance to play with it a bit more.

@larryhastings
Copy link
Contributor Author

I hear and obey--I'll hold off.

If any of the cherry-picks back into 3.3 have Misc/NEWS.d blurb entries, I guess you'll have two choices:

  1. Manually merge them into Misc/NEWS, or
  2. Run blurb split and blurb merge yourself as part of the release process, without checking in any of the intermediary files, just to regenerate Misc/NEWS. Then check your changes to Misc/NEWS in.
    This will have the happy side-effect of also updating your Misc/NEWS to the modern aesthetics (e.g. bpo-, section name "macOS").

I think 2. is the way to go, personally; it seems like a very sensible approach to handling the end-of-life 3.3 branch overall. Misc/NEWS will remain where it is so it won't affect the Doc build process.

@ned-deily
Copy link
Member

Yeah, I think running blurb split and blurb merge manually during the release tagging makes sense to get the updated references. I'll plan to do that.

@ned-deily ned-deily closed this Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants