Skip to content

bpo-44647: Add a permanent Unicode-valued env var to regrtest #27187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2021
Merged

bpo-44647: Add a permanent Unicode-valued env var to regrtest #27187

merged 2 commits into from
Jul 16, 2021

Conversation

@ambv
Copy link
Contributor

@ambv ambv commented Jul 16, 2021 •
edited by bedevere-bot
Loading

Added a permanent Unicode-valued environment variable to regression tests to
ensure they handle this use case in the future. If your test environment
breaks because of that, report a bug to us, and temporarily set
PYTHONREGRTEST_UNICODE_GUARD=0 in your test environment.

https://bugs.python.org/issue44647

@ambv ambv requested a review from zooba July 16, 2021 12:07
@ambv ambv merged commit 7915c96 into python:main Jul 16, 2021
@bedevere-bot
Copy link

bedevere-bot commented Jul 16, 2021

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@ambv ambv deleted the test-unicode-guard branch July 16, 2021 13:24
@ambv ambv added the needs backport to 3.10 only security fixes label Jul 16, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Jul 16, 2021

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jul 16, 2021

GH-27191 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 16, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2021
@ambv @miss-islington
bpo-44647: Add a permanent Unicode-valued env var to regrtest (python…
4eea6d7 
…GH-27187)

(cherry picked from commit 7915c96)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Jul 16, 2021
@miss-islington @ambv
bpo-44647: Add a permanent Unicode-valued env var to regrtest (GH-27187…
93d36a5 
…) (#27191)

(cherry picked from commit 7915c96)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@ambv ambv mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@zooba zooba Awaiting requested review from zooba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ambv @bedevere-bot @miss-islington @pablogsal @the-knights-who-say-ni