-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-44958: Only reset sqlite3
statements when needed
#27844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pablogsal
merged 16 commits into
python:main
from
erlend-aasland:sqlite-optimise-resets
Sep 21, 2021
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
99adc05
bpo-44958: Only reset sqlite3 statements when needed
2f8cb23
We don't use the return value of pysqlite_statement_reset
e6e4973
If possible, avoid resetting unused statements
df769c3
SQLITE_STMTSTATUS_RUN is available from 3.20.0 and onwards
cbcd640
Use sqlite3_stmt pointer iso. deref'ing self when calling sqlite3_reset
fe0fd6f
Merge branch 'main' into sqlite-optimise-resets
0633095
Sync with 'main' bco. GH-27884
06e242c
pysqlite_statement_reset result() is never used => return void
747000c
Sync with `main` bco. GH-27942
4ad7e99
Make sure we reset statements both at cursor dealloc and when the
1bbb31f
Harden test_type_map_usage()
73e1ddb
Add regression tests for stmt exit from cursor
9684593
Merge branch 'main' into sqlite-optimise-resets
41410e0
Merge branch 'main' into sqlite-optimise-resets
ebebdb7
Merge branch 'main' into sqlite-optimise-resets
c84311e
Test that datamodifying select queries are marked readonly
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.