bpo-44926: get_type_hints: Add note about type aliases with forward refs
#27859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Looks good, I just have one comment.
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
Contributor
|
Thanks @mhils for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
@gvanrossum: Please replace |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 20, 2021
… refs (pythonGH-27859) (cherry picked from commit 16b9be4) Co-authored-by: Maximilian Hils <git@maximilianhils.com>
|
GH-27860 is a backport of this pull request to the 3.10 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed on in bpo-44926, this PR adds a small note to
typing.get_type_hintsexplaining that it fails on type aliases with forward references imported from other modules.I've tried to keep the text short. The first commit has a slightly longer version if we want more details/explanation here, but I think this should be enough. :)
https://bugs.python.org/issue44926