-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
bpo-44962 fix a race in WeakKeyDict, WeakValueDict and WeakSet when two threads attempt to commit the last pending removal #27921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5a0dc76
bpo-44962 fix a race in WeakSet
graingert 3f74f24
📜🤖 Added by blurb_it.
blurb-it[bot] 08f31cb
Update Misc/NEWS.d/next/Core and Builtins/2021-08-23-19-55-08.bpo-449…
graingert 738dc9a
fix races in WeakKeyDict and WeakValueDict
graingert f3585ef
catch KeyError in WeakKeyDict callback
graingert 6476722
Update Misc/NEWS.d/next/Core and Builtins/2021-08-23-19-55-08.bpo-449…
graingert 36fd3f0
Update Misc/NEWS.d/next/Core and Builtins/2021-08-23-19-55-08.bpo-449…
graingert 54a0032
Update Lib/weakref.py
graingert aada0e4
cache _atomic_removal in WeakValueDictionary._commit_removals
graingert b2b25d0
remove redundant else clauses
graingert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Core and Builtins/2021-08-23-19-55-08.bpo-44962.J00ftt.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| fix a race in WeakSet | ||
graingert marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.