Skip to content

bpo-31299: make it possible to filter out frames from tracebacks #28067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 31, 2021
Merged

bpo-31299: make it possible to filter out frames from tracebacks #28067

merged 3 commits into from
Aug 31, 2021

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 30, 2021 •
edited by bedevere-bot
Loading

@iritkatriel iritkatriel requested a review from ammaraskar August 30, 2021 13:49
ammaraskar
ammaraskar approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@ammaraskar ammaraskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good split of the original PR to filter out frames. Like you said, it should allow for a fix to the unittest bug. I also believe it will meet IDLE's needs though not as cleanly as the public API from the previous PR.

@iritkatriel iritkatriel merged commit 863154c into python:main Aug 31, 2021
@iritkatriel iritkatriel deleted the bpo-31299a branch November 5, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammaraskar ammaraskar ammaraskar approved these changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iritkatriel @ammaraskar @the-knights-who-say-ni @bedevere-bot