Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40360: [doc] Rephrase deprecation note about lib2to3 #28122

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Sep 2, 2021

The previous wording was written in a future tense and incorrectly assumed we would fully deprecate lib2to3 in Python 3.10 but we missed the boat for that.

https://bugs.python.org/issue40360

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

I didn't touch the doc, since I didn't know if we still could deprecate in 3.10, or if 3.11 was a more reasonable option (it is).

@ambv ambv merged commit f0b63d5 into python:main Sep 2, 2021
@miss-islington
Copy link
Contributor

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@ambv ambv deleted the rephrase-lib2to3-deprecation branch September 2, 2021 15:12
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 2, 2021
)

(cherry picked from commit f0b63d5)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 2, 2021
@bedevere-bot
Copy link

GH-28127 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Sep 2, 2021
(cherry picked from commit f0b63d5)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants