bpo-45094: Add Py_ALWAYS_INLINE macro #28141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Py_ALWAYS_INLINE macro to ask the compiler to always inline a static inline function. Use Py_ALWAYS_INLINE on static inline functions: * Py_DECREF(), Py_XDECREF() * Py_INCREF(), Py_XINCREF() * Py_IS_TYPE() * Py_NewRef(), Py_XNewRef() * Py_REFCNT() * Py_SET_REFCNT(), Py_SET_SIZE(), Py_SET_TYPE()
Include/pyport.h
Outdated
| @@ -557,6 +557,28 @@ extern "C" { | |||
| #define _Py_HOT_FUNCTION | |||
| #endif | |||
|
|
|||
| // Ask the compiler to always inline a static inline function. The compiler is | |||
| // free is ignored this "hint". This attribute can be used to avoid increasing | |||
There was a problem hiding this comment.
Suggested change
| // free is ignored this "hint". This attribute can be used to avoid increasing | |
| // free to ignore this "hint". This attribute can be used to avoid increasing |
erlend-aasland
approved these changes
Sep 3, 2021
|
Sadly, it doesn't seem to solve PR #28128 problem. |
|
I rejected https://bugs.python.org/issue45094#msg401272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Py_ALWAYS_INLINE macro to ask the compiler to always inline a
static inline function.
Use Py_ALWAYS_INLINE on static inline functions:
https://bugs.python.org/issue45094