-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
bpo-45115: Enable optimiaztions on Windows debug build #28181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On Windows, enable compiler optimizations on the debug build to make tests run faster and to reduce the stack memory usage, especially with static inline functions used in Python public header files. The Windows GitHub Actions now build Python in debug mode to catch more bugs.
I modified my PR #28128 to see if enabling compiler optimizations fix test_exceptions when Py_TYPE() macro is converted to a static inline function. |
[Reference] Timing of a release build (with optimizations), from PR #28180:
[With this PR] GitHub Action jobs with Python built in debug mode with optimizations:
Currently, the slowest job is the Address Sanitizer. IMO as soon as the Windows jobs are faster than the Address Sanitizer job, the little slowdown of this PR on GitHub Action is accepted. And it's way better to test Python on Windows in debug mode! |
Building Python in debug mode does fix test_exceptions crash when Py_TYPE() macro is converted to a static inline function: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this PR explicitly until we've had the discussion on the issue tracker.
When you're done making the requested changes, leave the comment: |
Ok, I convert this PR to a draft to prevent merging it by mistake. |
I rejected my issue: https://bugs.python.org/issue45115#msg401273 |
On Windows, enable compiler optimizations on the debug build to make
tests run faster and to reduce the stack memory usage, especially
with static inline functions used in Python public header files.
The Windows GitHub Actions now build Python in debug mode to catch
more bugs.
https://bugs.python.org/issue45115