Skip to content

bpo-45160: Ttk optionmenu only set variable once #28291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ambv merged 3 commits into from
Oct 21, 2021
Merged

bpo-45160: Ttk optionmenu only set variable once #28291

ambv merged 3 commits into from
Oct 21, 2021

Conversation

@E-Paine
Copy link
Contributor

@E-Paine E-Paine commented Sep 11, 2021 •
edited by bedevere-bot
Loading

Since we were manually setting the variable (as well as the radiobutton), callbacks registered using the variable's trace method would be called twice.

TODO: Tests

Note: I probably won't be able to look at this now for ~ a week.

https://bugs.python.org/issue45160

serhiy-storchaka
serhiy-storchaka reviewed Sep 11, 2021
View reviewed changes
@E-Paine E-Paine marked this pull request as ready for review September 17, 2021 16:34
@github-actions
Copy link

github-actions bot commented Oct 18, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Oct 18, 2021
@ambv ambv merged commit add46f8 into python:main Oct 21, 2021
@ambv ambv added the needs backport to 3.10 only security fixes label Oct 21, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Oct 21, 2021

Thanks @E-Paine for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 21, 2021

GH-29131 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 21, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Oct 21, 2021

Thanks @E-Paine for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 21, 2021

Thanks @E-Paine for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 21, 2021

GH-29132 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2021
@E-Paine @miss-islington
bpo-45160: Ttk optionmenu only set variable once (pythonGH-28291)
1065c4d 
(cherry picked from commit add46f8)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2021
@E-Paine @miss-islington
bpo-45160: Ttk optionmenu only set variable once (pythonGH-28291)
6064b13 
(cherry picked from commit add46f8)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
@ambv ambv removed the needs backport to 3.10 only security fixes label Oct 21, 2021
ambv pushed a commit that referenced this pull request Oct 21, 2021
@miss-islington @E-Paine
bpo-45160: Ttk optionmenu only set variable once (GH-28291) (GH-29132)
04485ac 
(cherry picked from commit add46f8)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
ambv pushed a commit that referenced this pull request Oct 21, 2021
@miss-islington @E-Paine
bpo-45160: Ttk optionmenu only set variable once (GH-28291) (GH-29131)
98f157d 
(cherry picked from commit add46f8)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
ambv added a commit that referenced this pull request Nov 2, 2021
@ambv
Revert "bpo-45160: Ttk optionmenu only set variable once (GH-28291) (G…
76734ed 
…H-29132)"

This reverts commit 04485ac.
ambv added a commit that referenced this pull request Nov 3, 2021
@ambv
bpo-45160: Fix refleak in test_ttk_guionly introduced in GH-28291
4c9a5db
ambv added a commit that referenced this pull request Nov 4, 2021
@ambv
bpo-45160: Fix refleak in test_ttk_guionly introduced in GH-28291
9f3bca1
ambv added a commit to ambv/cpython that referenced this pull request Nov 4, 2021
@ambv
bpo-45160: Fix refleak in test_ttk_guionly introduced in pythonGH-28291
a5295c9
ambv added a commit that referenced this pull request Nov 5, 2021
@ambv
bpo-45160: Fix refleak in test_ttk_guionly introduced in GH-28291 (GH…
54d1e3f 
…-29416)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2021
@ambv @miss-islington
bpo-45160: Fix refleak in test_ttk_guionly introduced in pythonGH-28291…
291155b 
… (pythonGH-29416)

(cherry picked from commit 54d1e3f)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2021
@ambv @miss-islington
bpo-45160: Fix refleak in test_ttk_guionly introduced in pythonGH-28291…
19bd16f 
… (pythonGH-29416)

(cherry picked from commit 54d1e3f)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Nov 5, 2021
@miss-islington @ambv
bpo-45160: Fix refleak in test_ttk_guionly introduced in GH-28291 (GH…
276a3a6 
…-29416) (GH-29420)

(cherry picked from commit 54d1e3f)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Nov 5, 2021
@miss-islington @ambv
bpo-45160: Fix refleak in test_ttk_guionly introduced in GH-28291 (GH…
099a94f 
…-29416) (GH-29421)

(cherry picked from commit 54d1e3f)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

1 more reviewer

@fhdrsdg fhdrsdg fhdrsdg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@E-Paine @miss-islington @bedevere-bot @serhiy-storchaka @fhdrsdg @ambv @the-knights-who-say-ni