Skip to content

Also install __phello__, in addition to __hello__. #28665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Oct 1, 2021

(I was going to revert gh-28664, but realized what the problem was.)

I broke some buildbots by not adding phello to the list of installed packages.

https://bugs.python.org/issue45020

@ericsnowcurrently ericsnowcurrently requested a review from a team as a code owner October 1, 2021 01:45
@ericsnowcurrently ericsnowcurrently changed the title Revert "bpo-45020: Add more test cases for frozen modules. (gh-28664)" Revert "bpo-45020: Add more test cases for frozen modules." Oct 1, 2021
@ericsnowcurrently ericsnowcurrently changed the title Revert "bpo-45020: Add more test cases for frozen modules." Also install __phello__, in addition to __hello__. Oct 1, 2021
@ericsnowcurrently ericsnowcurrently merged commit 3e1c5d9 into python:main Oct 1, 2021
@bedevere-bot
Copy link

@ericsnowcurrently: Please replace # with GH- in the commit message next time. Thanks!

@ericsnowcurrently ericsnowcurrently deleted the fix-buildbot-failures branch October 1, 2021 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants