Skip to content

Fix a leak in _PyImport_LoadDynamicModuleWithSpec() after failing PySys_Audit() #28862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2021
Merged

Fix a leak in _PyImport_LoadDynamicModuleWithSpec() after failing PySys_Audit() #28862

merged 1 commit into from
Oct 11, 2021

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 11, 2021

No description provided.

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.9 needs backport to 3.10 only security fixes labels Oct 11, 2021
vstinner
vstinner approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nicely spotted ;-)

@serhiy-storchaka serhiy-storchaka merged commit 9883ca4 into python:main Oct 11, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2021

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2021
@serhiy-storchaka @miss-islington
Fix a leak in _PyImport_LoadDynamicModuleWithSpec() after failing PyS…
de1aa1a 
…ys_Audit() (pythonGH-28862)

(cherry picked from commit 9883ca4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 11, 2021

GH-28868 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 11, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2021
@serhiy-storchaka @miss-islington
Fix a leak in _PyImport_LoadDynamicModuleWithSpec() after failing PyS…
81b0c0e 
…ys_Audit() (pythonGH-28862)

(cherry picked from commit 9883ca4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 11, 2021

GH-28869 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Oct 11, 2021
@miss-islington @serhiy-storchaka
Fix a leak in _PyImport_LoadDynamicModuleWithSpec() after failing PyS…
3a58d60 
…ys_Audit() (GH-28862)

(cherry picked from commit 9883ca4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Oct 11, 2021
@miss-islington @serhiy-storchaka
Fix a leak in _PyImport_LoadDynamicModuleWithSpec() after failing PyS…
d57d33c 
…ys_Audit() (GH-28862)

(cherry picked from commit 9883ca4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@zooba zooba Awaiting requested review from zooba

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

skip issue skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni