bpo-43974: Move Py_BUILD_CORE_MODULE into module code (GH-29157) #29157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``setup.py`` no longer defines ``Py_BUILD_CORE_MODULE``. Instead every module defines the macro before ``#include "Python.h"`` unless ``Py_BUILD_CORE_BUILTIN`` is already defined. ``Py_BUILD_CORE_BUILTIN`` is defined for every module that is built by ``Modules/Setup``. Signed-off-by: Christian Heimes <christian@python.org>
Makefile and makesetup already define ``Py_BUILD_CORE_BUILTIN`` and include ``Modules/internal`` for us.
vstinner
reviewed
Oct 22, 2021
tiran
requested review from
a team,
1st1,
abalkin,
asvetlov,
gpshead,
pganssle and
rhettinger
as code owners
vstinner
approved these changes
Oct 22, 2021
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. I compared the list of modified files to setup.py. It seems like the PR is exhausitve.
Oh. I didn't know that Modules/makesetup already uses the correct flags for build C extensions depending if it's before or after *shared* in Modules/Setup:
PY_BUILTIN_MODULE_CFLAGS= $(PY_STDMODULE_CFLAGS) -DPy_BUILD_CORE_BUILTIN
PY_CORE_CFLAGS= $(PY_STDMODULE_CFLAGS) -DPy_BUILD_CORE
| @@ -0,0 +1,2 @@ | |||
| ``setup.py`` no longer defines ``Py_BUILD_CORE_MODULE``. Instead every | |||
Member
There was a problem hiding this comment.
You may also mention Modules/Setup.
Member
Author
There was a problem hiding this comment.
Oh. I didn't know that Modules/makesetup already uses the correct flags for build C extensions depending if it's before or after
*shared*in Modules/Setup:
There is a problem with *shared*. I created https://bugs.python.org/issue45571 to track the issue.
tiran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pyno longer definesPy_BUILD_CORE_MODULE. Instead everymodule defines the macro before
#include "Python.h"unlessPy_BUILD_CORE_BUILTINis already defined.Py_BUILD_CORE_BUILTINis defined for every module that is built byModules/Setup.The PR also simplifies
Modules/Setup.Makefileandmakesetupalready define
Py_BUILD_CORE_BUILTINand includeModules/internalfor us.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue43974