Skip to content

bpo-45573: Use pkg-config for Modules/Setup #29164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Oct 22, 2021

Use pkg-config and a modified version of
PKG_HAVE_DEFINE_WITH_MODULES to detect compiler flags and libraries
for Modules/Setup.

For now CPython does not use any of the new flags in setup.py. We may
expand the use of pkg-config once we are sure that it works properly on
our target platforms.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue45573

@tiran tiran force-pushed the configure_pkgconfig branch 2 times, most recently from 2413d8d to 30f60ac Compare October 22, 2021 16:54
@tiran tiran requested a review from brettcannon October 22, 2021 16:58
@tiran tiran force-pushed the configure_pkgconfig branch from 30f60ac to 4f5374f Compare October 25, 2021 18:18
tiran added 5 commits October 26, 2021 12:26
``makesetup`` puts shared extensions into ``Modules/`` directory. Create
symlinks from pybuilddir so the extensions can be imported.

Note: It is not possible to use the content of pybuilddir.txt as a build
target. Makefile evaluates target variables in the first pass. The
pybuilddir.txt file does not exist at that point.

Signed-off-by: Christian Heimes <christian@python.org>
Use pkg-config and a modified version of
``PKG_HAVE_DEFINE_WITH_MODULES`` to detect compiler flags and libraries
for ``Modules/Setup``.

For now CPython does not use any of the new flags in setup.py. We may
expand the use of pkg-config once we are sure that it works properly on
our target platforms.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran force-pushed the configure_pkgconfig branch from 4f5374f to 310c4e3 Compare October 26, 2021 14:53
@brettcannon
Copy link
Member

Once this leaves the draft stage and my review is still desired, please feel free to add the review request back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants