Skip to content

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 30, 2021

This is the first PR for this issue (I plan to make the second one with dis.findlabels tests).

https://bugs.python.org/issue45578

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 30, 2021
@ambv ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 2, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ambv for commit 79b77da 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 2, 2021
@ambv
Copy link
Contributor

ambv commented Nov 2, 2021

Adding buildbot tests as meddling with global state usually causes refleaks or environment change failures.

@sobolevn
Copy link
Member Author

sobolevn commented Nov 3, 2021

Is it related?

----------------------------------------------------------------------
Ran 1 test in 0.001s
OK
......
1 test failed again:
    test_sqlite3
== Tests result: FAILURE then FAILURE ==
415 tests OK.
10 slowest tests:
- test_signal: 31 min 9 sec
- test_pydoc: 29 min 44 sec
- test_asyncio: 18 min 44 sec
- test_concurrent_futures: 18 min 24 sec
- test_multiprocessing_spawn: 15 min 42 sec
- test_peg_generator: 15 min 23 sec
- test_multiprocessing_forkserver: 9 min 37 sec
- test_multiprocessing_fork: 8 min 25 sec
- test_gdb: 8 min 23 sec
- test_pickle: 5 min 10 sec
1 test failed:
    test_sqlite3
14 tests skipped:
    test_devpoll test_ioctl test_kqueue test_msilib test_smtpnet
    test_ssl test_startfile test_tix test_tk test_ttk_guionly
    test_winconsoleio test_winreg test_winsound test_zipfile64
2 re-run tests:
    test_sqlite3 test_unittest
Total duration: 45 min 44 sec
Tests result: FAILURE then FAILURE
make: *** [Makefile:1357: buildbottest] Error 2
program finished with exit code 2
elapsedTime=2746.496299

@ambv
Copy link
Contributor

ambv commented Nov 3, 2021

This is indeed unrelated, Nikita. It's fixed by GH-29382 already.

@ambv ambv merged commit e346f19 into python:main Nov 3, 2021
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @sobolevn and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e346f196819aeb02a8a94205ce3e1536c4c2f105 3.10

@miss-islington
Copy link
Contributor

Sorry @sobolevn and @ambv, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e346f196819aeb02a8a94205ce3e1536c4c2f105 3.9

@bedevere-bot
Copy link

GH-29385 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 3, 2021
ambv pushed a commit to ambv/cpython that referenced this pull request Nov 3, 2021
(cherry picked from commit e346f19)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
ambv pushed a commit to ambv/cpython that referenced this pull request Nov 3, 2021
(cherry picked from commit e346f19)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-29386 is a backport of this pull request to the 3.9 branch.

ambv added a commit that referenced this pull request Nov 3, 2021
(cherry picked from commit e346f19)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
ambv added a commit that referenced this pull request Nov 3, 2021
(cherry picked from commit e346f19)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants