Skip to content

bpo-45709: Fix tracing when exception is handled. #29638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions Lib/test/test_sys_settrace.py
Original file line number Diff line number Diff line change
Expand Up @@ -1137,6 +1137,38 @@ def func():
(7, 'line'),
(7, 'return')])

def test_tracing_exception_raised_in_with(self):

class NullCtx:
def __enter__(self):
return self
def __exit__(self, *excinfo):
pass

def func():
try:
with NullCtx():
1/0
except ZeroDivisionError:
pass

self.run_and_compare(func,
[(0, 'call'),
(1, 'line'),
(2, 'line'),
(-5, 'call'),
(-4, 'line'),
(-4, 'return'),
(3, 'line'),
(3, 'exception'),
(2, 'line'),
(-3, 'call'),
(-2, 'line'),
(-2, 'return'),
(4, 'line'),
(5, 'line'),
(5, 'return')])


class SkipLineEventsTraceTestCase(TraceTestCase):
"""Repeat the trace tests, but with per-line events skipped"""
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Restore behavior from 3.10 when tracing an exception raised within a with
statement.
5 changes: 1 addition & 4 deletions Python/ceval.c
Original file line number Diff line number Diff line change
Expand Up @@ -5093,10 +5093,7 @@ MISS_WITH_OPARG_COUNTER(STORE_SUBSCR)
JUMPTO(handler);
/* Resume normal execution */
frame->f_state = FRAME_EXECUTING;
frame->f_lasti = handler;
NEXTOPARG();
PRE_DISPATCH_GOTO();
DISPATCH_GOTO();
DISPATCH();
}

exiting:
Expand Down