bpo-21987: fix TarFile.getmember getting a dir with a trailing slash #30283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lib/test/test_tarfile.py
Outdated
| self.add_dir_and_getmember('a'*101) | ||
|
|
||
| def add_dir_and_getmember(self, name): | ||
| tar = tarfile.open(tmpname, 'w') |
There was a problem hiding this comment.
Use context managers.
You can use temp_cwd() and temp_dir() from test.support.os_helper for creating temporary dirs.
Lib/test/test_tarfile.py
Outdated
Comment on lines
237
to
238
| tar.getmember(name) | ||
| tar.getmember(name + '/') |
There was a problem hiding this comment.
Maybe test that these two return the same info.
JelleZijlstra
approved these changes
Jan 19, 2022
serhiy-storchaka
approved these changes
Jan 21, 2022
serhiy-storchaka
added
needs backport to 3.9
|
Thanks @akulakov for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 21, 2022
…ythonGH-30283) (cherry picked from commit cfadcc3) Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
|
GH-30737 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 21, 2022
…ythonGH-30283) (cherry picked from commit cfadcc3) Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
|
GH-30738 is a backport of this pull request to the 3.9 branch. |
|
Serhiy and Jelle, thanks for reviewing! |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jan 23, 2022
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…slash (pythonGH-30283) (pythonGH-30738) (cherry picked from commit cfadcc3) Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue21987
Co-authored with Matt Behrens