Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46278: Reflect 'context' arg in 'AbstractEventLoop.call_*()' methods #30427

Merged
merged 1 commit into from
Jan 6, 2022
Merged

bpo-46278: Reflect 'context' arg in 'AbstractEventLoop.call_*()' methods #30427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Lib/asyncio/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,13 +257,13 @@ def _timer_handle_cancelled(self, handle):
"""Notification that a TimerHandle has been cancelled."""
raise NotImplementedError

def call_soon(self, callback, *args):
def call_soon(self, callback, *args, context=None):
return self.call_later(0, callback, *args)

def call_later(self, delay, callback, *args):
def call_later(self, delay, callback, *args, context=None):
raise NotImplementedError

def call_at(self, when, callback, *args):
def call_at(self, when, callback, *args, cotext=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def call_at(self, when, callback, *args, cotext=None):
def call_at(self, when, callback, *args, context=None):

raise NotImplementedError

def time(self):
Expand All @@ -279,7 +279,7 @@ def create_task(self, coro, *, name=None):

# Methods for interacting with threads.

def call_soon_threadsafe(self, callback, *args):
def call_soon_threadsafe(self, callback, *args, context=None):
raise NotImplementedError

def run_in_executor(self, executor, func, *args):
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2022-01-06-13-38-00.bpo-46278.wILA80.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Reflect ``context`` argument in ``AbstractEventLoop.call_*()`` methods. Loop
implementations already support it.