Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46345: add a test case for implicit Optional class attribute #30535

Merged
merged 1 commit into from
Jan 12, 2022
Merged

bpo-46345: add a test case for implicit Optional class attribute #30535

merged 1 commit into from
Jan 12, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 11, 2022 •
edited by gvanrossum
Loading

@sobolevn sobolevn mentioned this pull request Jan 11, 2022
Merged
Fidget-Spinner
Fidget-Spinner approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you suggest we backport this?

@sobolevn
Copy link
Member Author

Thanks for the review! 👍

I think it is safe to backport to 3.10 and 3.9

@sobolevn sobolevn added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jan 12, 2022
@gvanrossum
Copy link
Member

Looks like the issue-number bot is stuck. Closing and reopening to restart it (sigh).

@gvanrossum gvanrossum closed this Jan 12, 2022
@gvanrossum gvanrossum reopened this Jan 12, 2022
@gvanrossum gvanrossum merged commit 1de6015 into python:main Jan 12, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-30567 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 12, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2022
@sobolevn @miss-islington
bpo-46345: Add a test case for implicit Optional class attribute (p…
09cbc2e 
…ythonGH-30535)

(cherry picked from commit 1de6015)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2022
@sobolevn @miss-islington
bpo-46345: Add a test case for implicit Optional class attribute (p…
06e8491 
…ythonGH-30535)

(cherry picked from commit 1de6015)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 12, 2022
@bedevere-bot
Copy link

GH-30568 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jan 13, 2022
@miss-islington @sobolevn
bpo-46345: Add a test case for implicit Optional class attribute (G…
a468866 
…H-30535)

(cherry picked from commit 1de6015)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Jan 13, 2022
@miss-islington @sobolevn
bpo-46345: Add a test case for implicit Optional class attribute (G…
d9101c4 
…H-30535)

(cherry picked from commit 1de6015)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@sobolevn
Copy link
Member Author

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sobolevn @gvanrossum @miss-islington @bedevere-bot @JelleZijlstra @Fidget-Spinner @the-knights-who-say-ni