bpo-46421: Fix unittest filename evaluation when called as a module #30654

BaderSZ · 2022-01-18T00:38:21Z

See issue: https://bugs.python.org/issue46421

I stumbled across this issue when writing my own tests. I tried to run the tests as python -m unittest ./tests/*.py but failed. This surprisingly worked later when I removed the ./ from the beginning of the filename/directory.

Some investigation showed that the variable parts in Lib/unittest/loader.py:125 had a '.' in the beginning. Removing that fixed the issue.

make patchcheck passed
blurb added
ACKS added
Contributor agreement signed

https://bugs.python.org/issue46421

the-knights-who-say-ni · 2022-01-18T00:38:24Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@BaderSZ

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

BaderSZ · 2022-01-18T00:41:26Z

Our records indicate the following people have not signed the CLA:
...
If you have recently signed the CLA, please wait at least one business day before our records are updated.

I guess we'll wait the few business days.. :)

This is a better solution to the unittest fix that passes its own unit tests. Instead of filtering for ``None`` types, I just tear off the first dots in ``name``

BaderSZ · 2022-01-18T02:01:49Z

The latest commit fixes the pipelines.

Lib/unittest/loader.py

kumaraditya303

LGTM but a test would be required here. See https://devguide.python.org/runtests/

Lib/test/test_cmd_line.py

Lib/unittest/loader.py

bedevere-bot · 2022-03-16T13:15:31Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

BaderSZ · 2022-03-16T16:47:03Z

I have made the requested changes; please review again.

Lib/unittest/main.py

bedevere-bot · 2022-03-16T17:04:45Z

Thanks for making the requested changes!

@JelleZijlstra: please review the changes made to this pull request.

BaderSZ · 2022-03-16T18:04:23Z

Good thing I read the contribution docs. I was about to squash the commits. 😃 make, patchcheck, and unit tests pass on my end (GNU/Linux).

JelleZijlstra

Thanks! Going to try this out myself later today and then hopefully merge it.

JelleZijlstra

Tried it locally and it works great!

I noticed it also fixes invocations like ./python.exe -m unittest Lib/test/../test/test_longexp.py. We could add a test for that, but it's not particularly useful so I won't insist on it.

I'll merge this in the next few days and backport to 3.9 and 3.10.

JelleZijlstra · 2022-03-17T06:15:28Z

(MacOS CI is failing, but it looks unrelated to this change and didn't reproduce locally on my Mac.)

miss-islington · 2022-03-17T23:37:55Z

Thanks @BaderSZ for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

bedevere-bot · 2022-03-17T23:38:25Z

GH-31969 is a backport of this pull request to the 3.10 branch.

bedevere-bot · 2022-03-17T23:38:29Z

GH-31970 is a backport of this pull request to the 3.9 branch.

…ythonGH-30654) (cherry picked from commit a0db11b) Co-authored-by: Bader Zaidan <bader@zaidan.pw>

…H-30654) (cherry picked from commit a0db11b) Co-authored-by: Bader Zaidan <bader@zaidan.pw>

…dule (GH-30654) (GH-31970) (cherry picked from commit a0db11b) Co-authored-by: Bader Zaidan <bader@zaidan.pw>

…dule (pythonGH-30654) (pythonGH-31970) (cherry picked from commit a0db11b) Co-authored-by: Bader Zaidan <bader@zaidan.pw>

BaderSZ added 3 commits January 18, 2022 01:07

bpo-46421: fix local directory invocation error for unittest

d5b20ef

bpo-46421: add blurb file

6a89a1e

bpo-46421: add contributor name to ACKS

ecbf1d0

the-knights-who-say-ni added the CLA not signed label Jan 18, 2022

bedevere-bot added the awaiting review label Jan 18, 2022

bpo-46421: string stripping directory to pass tests

cb4e93f

This is a better solution to the unittest fix that passes its own unit tests. Instead of filtering for ``None`` types, I just tear off the first dots in ``name``

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Jan 18, 2022

sobolevn reviewed Jan 22, 2022

View reviewed changes

Lib/unittest/loader.py Outdated Show resolved Hide resolved

kumaraditya303 requested changes Jan 22, 2022

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Jan 22, 2022

fix-issue-46421: add cmd_line test for unittest call

344a5dd

sobolevn reviewed Jan 22, 2022

View reviewed changes

Lib/test/test_cmd_line.py Outdated Show resolved Hide resolved

BaderSZ and others added 3 commits January 22, 2022 21:14

fix-issue-46421: replace chdir with os_helper function

4034ad5

Merge branch 'python:main' into fix-issue-46421

95b7422

Merge branch 'python:main' into fix-issue-46421

8c10000

JelleZijlstra requested changes Mar 16, 2022

View reviewed changes

Lib/unittest/loader.py Outdated Show resolved Hide resolved

bedevere-bot added awaiting changes and removed awaiting core review labels Mar 16, 2022

JelleZijlstra self-assigned this Mar 16, 2022

bpo-46421: Fix leading character in _convert_name

1e2cda8

JelleZijlstra reviewed Mar 16, 2022

View reviewed changes

Lib/unittest/main.py Outdated Show resolved Hide resolved

bedevere-bot added awaiting change review and removed awaiting changes labels Mar 16, 2022

bedevere-bot requested a review from JelleZijlstra March 16, 2022 17:04

BaderSZ added 2 commits March 16, 2022 18:46

Merge remote-tracking branch 'upstream/main' into fix-issue-46421

3e62a94

bpo-46421: Replace lstrip with normpath for unittest libraries

4ac8b6b

JelleZijlstra approved these changes Mar 16, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Mar 16, 2022

JelleZijlstra closed this Mar 17, 2022

JelleZijlstra reopened this Mar 17, 2022

JelleZijlstra added needs backport to 3.9 needs backport to 3.10 labels Mar 17, 2022

JelleZijlstra approved these changes Mar 17, 2022

View reviewed changes

JelleZijlstra merged commit a0db11b into python:main Mar 17, 2022

bedevere-bot removed awaiting merge needs backport to 3.10 labels Mar 17, 2022

bedevere-bot removed the needs backport to 3.9 label Mar 17, 2022

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 17, 2022

bpo-46421: Fix unittest filename evaluation when called as a module (p…

5cad6a5

…ythonGH-30654) (cherry picked from commit a0db11b) Co-authored-by: Bader Zaidan <bader@zaidan.pw>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 17, 2022

bpo-46421: Fix unittest filename evaluation when called as a module (p…

d86f51f

…ythonGH-30654) (cherry picked from commit a0db11b) Co-authored-by: Bader Zaidan <bader@zaidan.pw>

miss-islington added a commit that referenced this pull request Mar 18, 2022

bpo-46421: Fix unittest filename evaluation when called as a module (G…

0b5f99a

…H-30654) (cherry picked from commit a0db11b) Co-authored-by: Bader Zaidan <bader@zaidan.pw>

JelleZijlstra pushed a commit that referenced this pull request Mar 18, 2022

[3.9] bpo-46421: Fix unittest filename evaluation when called as a mo…

1cab44d

…dule (GH-30654) (GH-31970) (cherry picked from commit a0db11b) Co-authored-by: Bader Zaidan <bader@zaidan.pw>

BaderSZ mannequin mentioned this pull request Apr 10, 2022

unittest ValueError when invoking as module #90579

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-46421: Fix unittest filename evaluation when called as a module #30654

bpo-46421: Fix unittest filename evaluation when called as a module #30654

BaderSZ commented Jan 18, 2022 •

edited by bedevere-bot

Loading

the-knights-who-say-ni commented Jan 18, 2022

BaderSZ commented Jan 18, 2022

BaderSZ commented Jan 18, 2022

kumaraditya303 left a comment

bedevere-bot commented Mar 16, 2022

BaderSZ commented Mar 16, 2022

bedevere-bot commented Mar 16, 2022

BaderSZ commented Mar 16, 2022

JelleZijlstra left a comment

JelleZijlstra left a comment

JelleZijlstra commented Mar 17, 2022 •

edited

Loading

miss-islington commented Mar 17, 2022

bedevere-bot commented Mar 17, 2022

bedevere-bot commented Mar 17, 2022

bpo-46421: Fix unittest filename evaluation when called as a module #30654

bpo-46421: Fix unittest filename evaluation when called as a module #30654

Conversation

BaderSZ commented Jan 18, 2022 • edited by bedevere-bot Loading

the-knights-who-say-ni commented Jan 18, 2022

CLA Missing

BaderSZ commented Jan 18, 2022

BaderSZ commented Jan 18, 2022

kumaraditya303 left a comment

Choose a reason for hiding this comment

bedevere-bot commented Mar 16, 2022

BaderSZ commented Mar 16, 2022

bedevere-bot commented Mar 16, 2022

BaderSZ commented Mar 16, 2022

JelleZijlstra left a comment

Choose a reason for hiding this comment

JelleZijlstra left a comment

Choose a reason for hiding this comment

JelleZijlstra commented Mar 17, 2022 • edited Loading

miss-islington commented Mar 17, 2022

bedevere-bot commented Mar 17, 2022

bedevere-bot commented Mar 17, 2022

BaderSZ commented Jan 18, 2022 •

edited by bedevere-bot

Loading

JelleZijlstra commented Mar 17, 2022 •

edited

Loading