Skip to content

[3.8] bpo-46648: Skip test_urllib2.test_issue16464() (GH-31161) #31173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 6, 2022

POST requests to http://www.example.com/ fail randomly.
(cherry picked from commit 1578de2)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue46648

POST requests to http://www.example.com/ fail randomly.
(cherry picked from commit 1578de2)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@vstinner
Copy link
Member

vstinner commented Feb 6, 2022

@ambv: You may want to get this fix. The 10 Refleaks 3.8 buildbots are failing because of test_urllib2: https://buildbot.python.org/all/#/release_status

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@gpshead
Copy link
Member

gpshead commented Feb 7, 2022

fwiw, a more proper fix to backport is coming in #31186. but it probably doesn't matter which one is chosen for 3.8 as it's not like the code this is testing behavior of could ever change in this branch.

@ambv ambv merged commit f87e616 into python:3.8 Feb 8, 2022
@miss-islington miss-islington deleted the backport-1578de2-3.8 branch February 8, 2022 09:52
@vstinner
Copy link
Member

vstinner commented Feb 8, 2022

Thanks for the merge @ambv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants