Skip to content

bpo-46494: Mention the typing_extensions pkg in typing docs #31260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 8, 2022
Merged

bpo-46494: Mention the typing_extensions pkg in typing docs #31260

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a763bc8
Mention the typing_extensions pkg in typing docs
meersuri Feb 10, 2022
d6bded3
Clarify the description of typing_extensions
meersuri Feb 11, 2022
155f1ac
Make the python version part more explicit
meersuri Feb 19, 2022
278c177
Update wording
meersuri Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Doc/library/typing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ In the function ``greeting``, the argument ``name`` is expected to be of type
:class:`str` and the return type :class:`str`. Subtypes are accepted as
arguments.

New features have been added to the typing module in each version of Python.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
New features have been added to the typing module in each version of Python.
New features are frequently added to the ``typing`` module.

So this doesn't go out of date if we don't end up adding anything to 3.12 or something.

The `typing_extensions <https://pypi.org/project/typing-extensions/>`_ package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you fully removed the first sentence? I'd like to make it more explicit that the fact that all these new things were added to recent versions doesn't mean you can't use them in older versions.

Copy link
Contributor Author

@meersuri meersuri Feb 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I read the rephrasing and felt that it covered the important points from both sentences so I thought that the intention was to have only the rephrased sentence, but it seems that I misunderstood what you meant. Is the following what was intended -
New features have been added to the typing module in each version of Python. The typing_extensions package provides backports of new ``typing`` features to older versions of Python.
Edit: I realized I missed your first comment about the versions of Python - updated the text above, based on that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you didn't push any more changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed now. Sorry, this time I thought I would get feedback before pushing

provides backports of new ``typing`` features to older versions of Python.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
provides backports of new ``typing`` features to older versions of Python.
provides backports of these new features to older versions of Python.

Don't repeat "typing"


.. _relevant-peps:

Relevant PEPs
Expand Down