Skip to content

bpo-46541: Remove usage of _Py_IDENTIFIER from mmap module #31375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Modules/mmapmodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
#ifndef Py_BUILD_CORE_BUILTIN
# define Py_BUILD_CORE_MODULE 1
#endif
#define NEEDS_PY_IDENTIFIER

#define PY_SSIZE_T_CLEAN
#include <Python.h>
Expand Down Expand Up @@ -771,9 +770,7 @@ mmap__enter__method(mmap_object *self, PyObject *args)
static PyObject *
mmap__exit__method(PyObject *self, PyObject *args)
{
_Py_IDENTIFIER(close);

return _PyObject_CallMethodIdNoArgs(self, &PyId_close);
return mmap_close_method((mmap_object *)self, NULL);
}

static PyObject *
Expand Down