Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46857: Fix test_embed.test_no_memleak() on Windows #31589

Merged
merged 1 commit into from
Feb 25, 2022
Merged

bpo-46857: Fix test_embed.test_no_memleak() on Windows #31589

merged 1 commit into from
Feb 25, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Feb 25, 2022

Tolerate a leak of 1 reference and 1 memory block until it's fixed.

https://bugs.python.org/issue46857

Tolerate a leak of 1 reference and 1 memory block until it's fixed.
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll try to find the leak but till then it is good enough.

@vstinner
Copy link
Member Author

LGTM, I'll try to find the leak

Good luck! It can be a bug which exists for many years. See for example my winreg.c fix, it was an old bug.

@vstinner vstinner merged commit ea9612a into python:main Feb 25, 2022
@vstinner vstinner deleted the leak_win branch February 25, 2022 17:24
asvetlov pushed a commit that referenced this pull request Feb 26, 2022
Tolerate a leak of 1 reference and 1 memory block until it's fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants