Skip to content

bpo-46878: Purge 'non-standard' from sqlite3 docstrings #31612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2022
Merged

bpo-46878: Purge 'non-standard' from sqlite3 docstrings #31612

merged 1 commit into from
Mar 8, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 28, 2022 •
edited by bedevere-bot
Loading

@erlend-aasland erlend-aasland mentioned this pull request Feb 28, 2022
Merged
@AlexWaygood AlexWaygood added the docs Documentation in the Doc dir label Feb 28, 2022
@JelleZijlstra JelleZijlstra self-assigned this Feb 28, 2022
JelleZijlstra
JelleZijlstra approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

Do you think we should backport this change? I imagine it will make future backports easier if we keep the docstrings similar.

@erlend-aasland
Copy link
Contributor Author

Looks good, thanks.

Thanks for reviewing! Much appreciated.

Do you think we should backport this change? I imagine it will make future backports easier if we keep the docstrings similar.

Definitely.

@erlend-aasland erlend-aasland added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Mar 2, 2022
@JelleZijlstra
Copy link
Member

Going to merge this change soon (cc @gvanrossum).

@JelleZijlstra JelleZijlstra merged commit 4d95fa1 into python:main Mar 8, 2022
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland and @JelleZijlstra, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4d95fa1ac5d31ff450fb2f31b55ce1eb99d6efcb 3.10

@miss-islington
Copy link
Contributor

Sorry @erlend-aasland and @JelleZijlstra, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 4d95fa1ac5d31ff450fb2f31b55ce1eb99d6efcb 3.9

@erlend-aasland erlend-aasland deleted the sqlite-non-standard branch March 8, 2022 08:25
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 8, 2022
@bedevere-bot
Copy link

GH-31753 is a backport of this pull request to the 3.10 branch.

@erlend-aasland erlend-aasland mentioned this pull request Mar 8, 2022
Merged
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 8, 2022
@bedevere-bot
Copy link

GH-31754 is a backport of this pull request to the 3.9 branch.

@erlend-aasland erlend-aasland mentioned this pull request Mar 8, 2022
Merged
miss-islington pushed a commit that referenced this pull request Mar 8, 2022
[3.10] bpo-46878: Purge 'non-standard' from sqlite3 docstrings (GH-31612
f3d3b2d 
) (GH-31753)

(cherry picked from commit 4d95fa1)
miss-islington pushed a commit that referenced this pull request Mar 8, 2022
[3.9] bpo-46878: Purge 'non-standard' from sqlite3 docstrings (GH-31612…
653ca6c 
…) (GH-31754)

(cherry picked from commit 4d95fa1)
@erlend-aasland erlend-aasland mentioned this pull request Apr 10, 2022
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@hello-adam
[3.9] bpo-46878: Purge 'non-standard' from sqlite3 docstrings (python…
fbff1e0 
…GH-31612) (pythonGH-31754)

(cherry picked from commit 4d95fa1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@erlend-aasland @JelleZijlstra @miss-islington @bedevere-bot @gpshead @the-knights-who-say-ni @AlexWaygood