Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-89263: Add typing.get_overloads #31716
gh-89263: Add typing.get_overloads #31716
Changes from all commits
2ee377d
831b565
f03f8a9
404668a
7a5b0d1
6998255
26bb908
f52b757
fc6a925
b524244
e95558e
31fd72d
7041ad3
e26b0db
1bf89fb
83ac432
dfdbdc7
e16c8d0
b3d2227
9727eee
2e374b8
ff03b12
17f0710
2346970
f2053a0
b6131ad
506bd66
e9a2100
2b1a5cc
103bfd4
d453f7f
450afeb
ea62287
905253c
debbf8a
754c134
1ad8224
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence sounds quite strange to me:
But I'm not sure I have a better suggestion off the top of my head ://
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, unfortunately the
overload
docs don't have a clear term for the implementation function either.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nit -- this paragraph starts off using the imperative mood
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the previous sentence is in the indicative, so I think this is fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it's not really a big deal either way :)