Skip to content

bpo-45150: Add hashlib.file_digest() for efficient file hashing #31930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 22, 2022
Merged

bpo-45150: Add hashlib.file_digest() for efficient file hashing #31930

merged 6 commits into from
Mar 22, 2022

Conversation

@tiran
Copy link
Member

@tiran tiran commented Mar 16, 2022 •
edited by miss-islington
Loading

https://bugs.python.org/issue45150

Automerge-Triggered-By: GH:tiran

@tiran tiran force-pushed the bpo-45150-file-digest branch from 1d6869b to 9b218da Compare March 16, 2022 12:33
@tiran tiran force-pushed the bpo-45150-file-digest branch from 9b218da to 71f0401 Compare March 16, 2022 12:38
@tiran tiran requested a review from gpshead March 16, 2022 14:37
gpshead
gpshead requested changes Mar 16, 2022
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you implemented this in pure Python.

@bedevere-bot
Copy link

bedevere-bot commented Mar 16, 2022

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@gpshead gpshead mentioned this pull request Mar 16, 2022
Closed
@tiran tiran requested a review from gpshead March 17, 2022 11:08
gpshead
gpshead reviewed Mar 17, 2022
View reviewed changes
@gpshead gpshead added the type-feature A feature request or enhancement label Mar 21, 2022
gpshead
gpshead reviewed Mar 21, 2022
View reviewed changes
@tiran tiran requested a review from gpshead March 22, 2022 07:45
@miss-islington miss-islington merged commit 4f97d64 into python:main Mar 22, 2022
@markshannon
Copy link
Member

markshannon commented Mar 22, 2022

This may have broken the buildbots.
https://buildbot.python.org/all/#/builders/713/builds/452

@tiran
Copy link
Member Author

tiran commented Mar 22, 2022

This may have broken the buildbots. buildbot.python.org/all/#/builders/713/builds/452

FIPS ... let's see if GH-32046 solves the issue.

@tiran tiran deleted the bpo-45150-file-digest branch March 22, 2022 13:24
@tiran tiran mentioned this pull request Apr 21, 2022
Closed
@tarekziade tarekziade mannequin mentioned this pull request Aug 13, 2022
Closed
musashay23

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

+1 more reviewer

@musashay23 musashay23 musashay23 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tiran @bedevere-bot @markshannon @gpshead @musashay23 @the-knights-who-say-ni @miss-islington