-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
bpo-31270: Simplify documentation of itertools.zip_longest #3200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
CLA is signed and submitted. Do I need to write a NEWS entry for this? I think it's rather "skip news", right? |
Thanks @raphaelm, I think news can be skipped for this one :) |
Hi @Mariatta, thanks for the quick answer! :) |
I prefer code that is closer to the actual implementation:
Also, please keep the leading whitespace the same as the original. Likewise, don't introduce blank lines into the code equivalents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See alternate implementation in the comments.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Moving this to an alternate pull request #3427 |
https://bugs.python.org/issue31270